dobesv commented on issue #1977: DRILL-7573: Support htpasswd based authentication URL: https://github.com/apache/drill/pull/1977#issuecomment-584926786 @paul-rogers I added some tests and cleaned up the logic slightly. I didn't add tests for the REST API, since the password logic is shared between both systems I don't think this requires separate testing. I couldn't figure out a sane way to test the stuff related to the default file and I didn't do anything related to loading the file from the classpath, I think that might be more than I am capable of with the time budget I have for this task right now. I welcome edits to the PR to implement that, but it didn't seem to be easy enough for me to justify spending hours on it when it's not really a very useful or important feature - I doubt anyone will use the default path in a real life situation, I just threw that in there as a minor convenience for testing purposes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
