paul-rogers commented on issue #1977: DRILL-7573: Support htpasswd based 
authentication
URL: https://github.com/apache/drill/pull/1977#issuecomment-585890405
 
 
   @vvysotskyi, in this case the sleep is necessary. As I read it, this code 
uses the file system for synchronization. We write a file, then make a request 
that will check the file timestamp. If that request is too fast, the code will 
not detect the change.
   
   Maybe 1 second is too long; maybe 100ms is plenty.
   
   But, without the delay, we need some other mechanism for synchronization, 
which then defeats the purpose of the code and test.
   
   You propose changing the file modification timestamp. This can be done, but 
will not accurately reproduce the use case that we want to test.
   
   Are you OK with a shorter delay?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to