paul-rogers commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE ... REFRESH METADATA does not work for empty Parquet files URL: https://github.com/apache/drill/pull/1985#discussion_r379850369
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/MetastoreAnalyzeTableHandler.java ########## @@ -406,13 +406,13 @@ private DrillRel getTableAggRelNode(DrillRel convertedRelNode, boolean createNew SchemaPath lastModifiedTimeField = SchemaPath.getSimplePath(config.getContext().getOptions().getString(ExecConstants.IMPLICIT_LAST_MODIFIED_TIME_COLUMN_LABEL)); - List<SchemaPath> excludedColumns = Arrays.asList(locationField, lastModifiedTimeField); + List<SchemaPath> nonSchemaColumns = Arrays.asList(locationField, lastModifiedTimeField); Review comment: Again, here and elsewhere, please pick a more descriptive name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services