KazydubB commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE
... REFRESH METADATA does not work for empty Parquet files
URL: https://github.com/apache/drill/pull/1985#discussion_r380231898
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/metadata/MetadataAggregateHelper.java
##########
@@ -117,16 +120,16 @@ private void createAggregatorInternal() {
}
}
- for (SchemaPath excludedColumn : excludedColumns) {
- if
(excludedColumn.equals(SchemaPath.getSimplePath(columnNamesOptions.rowGroupStart()))
- ||
excludedColumn.equals(SchemaPath.getSimplePath(columnNamesOptions.rowGroupLength())))
{
- LogicalExpression lastModifiedTime = new FunctionCall("any_value",
+ for (SchemaPath nonSchemaColumn : context.metadataColumns()) {
Review comment:
Rename to `metadataColumn` or `implicitColumn`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
