paul-rogers commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r380481139
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/work/filter/BloomFilterTest.java
##########
@@ -133,214 +135,227 @@ public boolean hasFailed() {
}
}
-
@Test
public void testNotExist() throws Exception {
- Drillbit bit = new Drillbit(c, RemoteServiceSet.getLocalServiceSet(),
ClassPathScanner.fromPrescan(c));
- bit.run();
- DrillbitContext bitContext = bit.getContext();
- FunctionImplementationRegistry registry =
bitContext.getFunctionImplementationRegistry();
- FragmentContextImpl context = new FragmentContextImpl(bitContext,
BitControl.PlanFragment.getDefaultInstance(), null, registry);
- BufferAllocator bufferAllocator = bitContext.getAllocator();
- //create RecordBatch
- VarCharVector vector = new VarCharVector(SchemaBuilder.columnSchema("a",
TypeProtos.MinorType.VARCHAR, TypeProtos.DataMode.REQUIRED), bufferAllocator);
- vector.allocateNew();
- int valueCount = 3;
- VarCharVector.Mutator mutator = vector.getMutator();
- mutator.setSafe(0, "a".getBytes());
- mutator.setSafe(1, "b".getBytes());
- mutator.setSafe(2, "c".getBytes());
- mutator.setValueCount(valueCount);
- VectorContainer vectorContainer = new VectorContainer();
- TypedFieldId fieldId = vectorContainer.add(vector);
- RecordBatch recordBatch = new TestRecordBatch(vectorContainer);
- //construct hash64
- ValueVectorReadExpression exp = new ValueVectorReadExpression(fieldId);
- LogicalExpression[] expressions = new LogicalExpression[1];
- expressions[0] = exp;
- TypedFieldId[] fieldIds = new TypedFieldId[1];
- fieldIds[0] = fieldId;
- ValueVectorHashHelper valueVectorHashHelper = new
ValueVectorHashHelper(recordBatch, context);
- ValueVectorHashHelper.Hash64 hash64 =
valueVectorHashHelper.getHash64(expressions, fieldIds);
-
- //construct BloomFilter
- int numBytes = BloomFilter.optimalNumOfBytes(3, 0.03);
-
- BloomFilter bloomFilter = new BloomFilter(numBytes, bufferAllocator);
- for (int i = 0; i < valueCount; i++) {
- long hashCode = hash64.hash64Code(i, 0, 0);
- bloomFilter.insert(hashCode);
+ int userPort = QueryTestUtil.getFreePortNumber(31170, 300);
+ int bitPort = QueryTestUtil.getFreePortNumber(31180, 300);
+ ClusterFixtureBuilder clusterFixtureBuilder =
ClusterFixture.bareBuilder(dirTestWatcher)
Review comment:
Do you need a full cluster for this? There is a `SubOperatorTest` that will
give you a fragment context and allocator so you can create vectors and invoke
"sub-operator" functionality such as the BloomFilter stuff.
If any of the code under tests needs the `DrillbitContext`, perhaps look at
modifying so that it doesn't. There is nothing a Bloom filter should need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
