vvysotskyi commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r380635376
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java
##########
@@ -73,31 +73,39 @@ private static void
enableDrillPortHunting(ClusterFixtureBuilder builder) {
builder.configBuilder.put(ExecConstants.DRILL_PORT_HUNT, true);
builder.configBuilder.put(ExecConstants.GRACE_PERIOD, 500);
builder.configBuilder.put(ExecConstants.ALLOW_LOOPBACK_ADDRESS_BINDING,
true);
+
+ setTestDirectories(builder);
+ }
+
+ private static void setTestDirectories(ClusterFixtureBuilder builder) {
+ builder.configBuilder.put(ExecConstants.DRILL_TMP_DIR,
dirTestWatcher.getTmpDir().getAbsolutePath());
+ builder.configBuilder.put(ExecConstants.SYS_STORE_PROVIDER_LOCAL_PATH,
dirTestWatcher.getStoreDir().getAbsolutePath());
Review comment:
`ClusterFixture` has already set these directories with correct values. It
was done here since instead on builder with test configuration was used
`bareBuilder`.
I have checked, and it also works with regular builder. So I have removed
these configs and replaced `bareBuilder` with `builder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
