paul-rogers commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r381482757
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/TestDynamicUDFSupport.java
##########
@@ -104,8 +104,10 @@ public static void buildAndStoreDefaultJars() throws
IOException {
@Before
public void setupNewDrillbit() throws Exception {
udfDir = dirTestWatcher.makeSubDir(Paths.get("udf"));
+ File udfLocalDir = dirTestWatcher.makeSubDir(Paths.get("udf", "local"));
Review comment:
Nice set of improvements in setting up the UDF dir. Looks very clean.
Should this code then use, say, `dirTestWatcher.getUdfDir()`? Or,
```
File udfLocalDir = new File(dirTestWatcher.getUdfDir(), "local");
```
Or, since the UDF code works from the locations set in the conf file, should
this be something like:
```
File udfLocalDir = new
File(config.getString(ExecConstants.UDF_DIRECTORY_LOCAL));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
