vvysotskyi commented on a change in pull request #1992: DRILL-7596: 
drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383141391
 
 

 ##########
 File path: contrib/format-esri/pom.xml
 ##########
 @@ -72,7 +72,7 @@
   <dependency>
     <groupId>org.apache.drill.contrib</groupId>
     <artifactId>drill-udfs</artifactId>
 
 Review comment:
   Is this dependency used in code, or it is required for tests only? If for 
tests, please specify the corresponding scope for it.
   Also, please fix the alignment of `<dependencies>` block, it should be 
indented with two spaces.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to