cgivre commented on a change in pull request #1992: DRILL-7596: 
drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383257998
 
 

 ##########
 File path: contrib/format-esri/pom.xml
 ##########
 @@ -18,7 +18,8 @@
     limitations under the License.
 
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 
 Review comment:
   Reverted first line spacing.  Just as a side note, I ran Drill's code 
formatting macro in Intellij which did this.  We might want to think about 
updating that so that this line is formatted correctly in future PRs, but that 
is out of scope for this PR. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to