arina-ielchiieva commented on a change in pull request #1988: DRILL-7590:
Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r383964144
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -23,9 +23,16 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
public abstract class StoragePluginConfig {
-
private Boolean enabled;
+ public StoragePluginConfig() {
+ enabled = true;
Review comment:
I am not sure this preserves initial behavior. As far as I remember boolean
wrapper class was used to cover problems when deserialized config did not
contain `enabled` status.
Could you please check history and ensure that nothing was broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
