arina-ielchiieva commented on a change in pull request #1988: DRILL-7590:
Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r383961105
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpConstraintSecurityHandler.java
##########
@@ -32,30 +32,31 @@
import static
org.apache.drill.exec.server.rest.auth.DrillUserPrincipal.AUTHENTICATED_ROLE;
/**
- * Accessor class that extends the ConstraintSecurityHandler to expose
protected method's for start and stop of Handler.
- * This is needed since now {@link DrillHttpSecurityHandlerProvider} composes
of 2 security handlers -
+ * Accessor class that extends the {@link ConstraintSecurityHandler} to expose
+ * protected method's for start and stop of Handler. This is needed since now
+ * {@code DrillHttpSecurityHandlerProvider} composes of 2 security handlers -
* For FORM and SPNEGO and has responsibility to start/stop of those handlers.
**/
public abstract class DrillHttpConstraintSecurityHandler extends
ConstraintSecurityHandler {
- @Override
- public void doStart() throws Exception {
- super.doStart();
- }
+ @Override
+ public void doStart() throws Exception {
+ super.doStart();
+ }
- @Override
- public void doStop() throws Exception {
- super.doStop();
- }
+ @Override
+ public void doStop() throws Exception {
+ super.doStop();
+ }
- public abstract void doSetup(DrillbitContext dbContext) throws
DrillException;
+ public abstract void doSetup(DrillbitContext dbContext) throws
DrillException;
- public void setup(LoginAuthenticator authenticator, LoginService
loginService) {
- final Set<String> knownRoles = ImmutableSet.of(AUTHENTICATED_ROLE,
ADMIN_ROLE);
- setConstraintMappings(Collections.<ConstraintMapping>emptyList(),
knownRoles);
- setAuthenticator(authenticator);
- setLoginService(loginService);
- }
+ public void setup(LoginAuthenticator authenticator, LoginService
loginService) {
+ final Set<String> knownRoles = ImmutableSet.of(AUTHENTICATED_ROLE,
ADMIN_ROLE);
+ setConstraintMappings(Collections.<ConstraintMapping>emptyList(),
knownRoles);
+ setAuthenticator(authenticator);
+ setLoginService(loginService);
+ }
- public abstract String getImplName();
+ public abstract String getImplName();
}
Review comment:
Add new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
