arina-ielchiieva commented on a change in pull request #1993: DRILL-7601: Shift
column conversion to reader from scan framework
URL: https://github.com/apache/drill/pull/1993#discussion_r384446888
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/project/Projections.java
##########
@@ -156,4 +157,8 @@ public static RequestedTuple build(List<RequestedColumn>
projList) {
}
return new RequestedTupleImpl(projList);
}
+
+ public static boolean isSpecial(ColumnMetadata col) {
Review comment:
Maybe change the naming? I am not sure that special correlates with the fact
that column should be excluded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
