arina-ielchiieva commented on a change in pull request #1993: DRILL-7601: Shift
column conversion to reader from scan framework
URL: https://github.com/apache/drill/pull/1993#discussion_r384444851
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/ColumnState.java
##########
@@ -285,31 +272,28 @@ public void rollover() {
* look-ahead vector and put the full vector buffer back into the active
* vector.
*/
-
public void harvestWithLookAhead() {
switch (state) {
- case NEW_LOOK_AHEAD:
-
- // If added after overflow, no data to save from the complete
- // batch: the vector does not appear in the completed batch.
-
- break;
+ case NEW_LOOK_AHEAD:
- case OVERFLOW:
+ // If added after overflow, no data to save from the complete
+ // batch: the vector does not appear in the completed batch.
+ break;
- // Otherwise, restore the original, full buffer and
- // last write position.
+ case OVERFLOW:
- vectorState.harvestWithLookAhead();
+ // Otherwise, restore the original, full buffer and
+ // last write position.
+ vectorState.harvestWithLookAhead();
- // Remember that we have look-ahead values stashed away in the
- // backup vector.
+ // Remember that we have look-ahead values stashed away in the
+ // backup vector.
- state = State.LOOK_AHEAD;
- break;
+ state= State.LOOK_AHEAD;
Review comment:
```suggestion
state = State.LOOK_AHEAD;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
