paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata Queries Fail with Large Files URL: https://github.com/apache/drill/pull/1978#discussion_r384866829
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -92,6 +93,18 @@ private static final String LONG_COLUMN_NAME = "long_data"; + private static final String DATA_SIZE_COLUMN_NAME = "data_size"; + + private static final String ELEMENT_COUNT_NAME = "element_count"; + + private static final String DATASET_DATA_TYPE_NAME = "dataset_data_type"; + + private static final String DIMENSIONS_FIELD_NAME = "dimensions"; + + private static final int PREVIEW_ROW_LIMIT = 20; + + private static final int MAX_DATASET_SIZE = 16777216; // 16MB Review comment: Nit: this can be better expressed as `16 * 1024 * 1024`. Or, since you are mimicking the max buffer size, set your constant to `ValueVector.MAX_BUFFER_SIZE`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
