paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384867611
##########
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##########
@@ -946,7 +990,11 @@ private void writeAttributes(TupleWriter rowWriter,
HDF5DrillMetadata record) {
writeLongColumn(mapWriter, key, (Long) attrib.getValue());
break;
case INT:
- writeIntColumn(mapWriter, key, (Integer) attrib.getValue());
+ try {
+ writeIntColumn(mapWriter, key, (Integer) attrib.getValue());
+ } catch (Exception e) {
+ logger.warn("{} {}", key, attrib);
Review comment:
Is this the right solution? What would cause the exception? If reading 100M
rows, do we want to emit 100M warnings into the log? Will the user understand
why the value in some column is null?
Should we be more selective: catching the (one) exception we want to ignore
and failing for all others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
