paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r384928614
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -23,9 +23,16 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
public abstract class StoragePluginConfig {
-
private Boolean enabled;
+ public StoragePluginConfig() {
+ enabled = true;
Review comment:
Removed. I'll fix this in the next PR. IMHO, plugins should start enabled,
and should become disabled only via config. (This is fine, because the only
three ways we create configs is 1) from the bootstrap plugins file, 2) user
copy & paste, and 3) in test code.)
The flag can be a primitive `boolean` as long as constructors accept a
`Boolean`.
The focus in this PR is on the registry; I (mostly) resisted the urge to fix
the plugin API in this PR, so I'll back out this change also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
