paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor 
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r385540454
 
 

 ##########
 File path: 
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
 ##########
 @@ -65,6 +65,7 @@ public static void setup() throws Exception {
 
     ExcelFormatConfig formatConfig = new ExcelFormatConfig();
     cluster.defineFormat("cp", "excel", formatConfig);
+    cluster.defineFormat("dfs", "excel", formatConfig);
 
 Review comment:
   I should have realized this was telling me something. Was due to my 
misunderstanding of how format plugin bootstrap works. Reverted change. And, 
added Excel to cp to avoid the need for the "cp" setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to