arina-ielchiieva commented on a change in pull request #2000: DRILL-7607:
Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386878197
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -1166,4 +1166,8 @@ public static String bootDefaultFor(String name) {
// Extra private plugin classes, used for testing
public static final String PRIVATE_CONNECTORS =
"drill.exec.storage.private_connectors";
+
+ public static final String ENABLE_DYNAMIC_CREDIT_BASED_FC =
"exec.enable_dynamic_fc";
+ public static final BooleanValidator
ENABLE_DYNAMIC_CREDIT_BASED_FC_VALIDATOR = new BooleanValidator(
+ ENABLE_DYNAMIC_CREDIT_BASED_FC, new OptionDescription("Enable
dynamic credit based flow control."));
Review comment:
Please add more details for user can understand the benefits of dynamic
credit flow, for example `... which allows ...` and `... should be used when
...`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
