arina-ielchiieva commented on a change in pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r386881973
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/data/TestBitRpc.java ########## @@ -94,6 +94,39 @@ public void testConnectionBackpressure() throws Exception { Thread.sleep(5000); } + @Test + public void testConnectionBackpressureWithDynamicCredit() throws Exception { + final WorkerBee bee = mock(WorkerBee.class); Review comment: There is a concept of effective final in java so it is not necessary to add final everywhere except of the cases you really won't to make a statement. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services