arina-ielchiieva commented on a change in pull request #2010: DRILL-7620: Fix
plugin mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r388149815
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java
##########
@@ -145,16 +216,42 @@ void putFormatPlugin(String pluginName, String
formatName,
* @param formatConfig
* The format config for the associated FormatPlugin
* @return A FormatPlugin instance
- * @throws ExecutionSetupException
+ * @throws PluginException
* if plugin cannot be obtained
*/
FormatPlugin getFormatPlugin(StoragePluginConfig storageConfig,
- FormatPluginConfig formatConfig) throws ExecutionSetupException;
+ FormatPluginConfig formatConfig) throws PluginException;
/**
* Get the Schema factory associated with this storage plugin registry.
*
* @return A SchemaFactory that can register the schemas associated with
this plugin registry.
*/
SchemaFactory getSchemaFactory();
+
+ /**
+ * Object mapper to read/write the JSON form of a plugin
+ * config.
+ * @return
Review comment:
Add description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
