arina-ielchiieva commented on a change in pull request #2010: DRILL-7620: Fix
plugin mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r388856474
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
##########
@@ -386,6 +387,20 @@ public void put(String name, StoragePluginConfig config)
throws PluginException
pluginStore.put(name, config);
}
+ @Override
+ public void validatedPut(String name, StoragePluginConfig config)
+ throws PluginException {
+
+ PluginHandle entry = createPluginEntry(name, config, PluginType.STORED);
+ try {
+ entry.plugin();
+ } catch (Exception e) {
+ throw new PluginException("Invalid plugin config", e);
Review comment:
Should we add plugin name to the error message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
