ihuzenko commented on a change in pull request #2012: DRILL-7625: Add options
for SslContextFactory
URL: https://github.com/apache/drill/pull/2012#discussion_r388825714
##########
File path:
common/src/main/java/org/apache/drill/common/config/NestedConfig.java
##########
@@ -111,6 +111,14 @@ public String getString(String path) {
return c.getString(path);
}
+ public String getString(String path, String defaultValue) {
Review comment:
won't it look strange that class and all its methods don't have Javadocs and
then BOOM -> one documented method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services