agozhiy commented on a change in pull request #2012: DRILL-7625: Add options
for SslContextFactory
URL: https://github.com/apache/drill/pull/2012#discussion_r390350047
##########
File path:
common/src/main/java/org/apache/drill/common/config/NestedConfig.java
##########
@@ -111,6 +112,19 @@ public String getString(String path) {
return c.getString(path);
}
+ /**
+ * Returns string option or passed default value if option is not set.
+ *
+ * @param path option path
+ * @param defaultValue default value
+ * @return option or default value
+ */
+ public String getString(String path, String defaultValue) {
Review comment:
There is no need for this method at all, default values can be set directly
in drill-module.conf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
