paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392608927
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/framework/ShimBatchReader.java
##########
@@ -131,6 +131,8 @@ public boolean next() {
eof = ! reader.next();
}
+ readerOrchestrator.setEof(eof);
Review comment:
Is there a need for this? The design is that EOF is indicated when:
* `open()` returns false. (As in an empty file with no schema. Think blank
CSV file.)
* `next()` returns false with no data. (Simple EOF.)
* `next()` returns false with data. EOF is on the next batch.
Eof handling logic is built into the `ScanOperatorExec` and, in particular,
the `ReaderState`. I worry about adding additional state that must be kept in
sync.
What is the intent here? Maybe I can help you find a solution that uses the
existing mechanisms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
