paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392608747
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/ImplicitColumnManager.java
##########
@@ -199,6 +192,21 @@ public ImplicitColumnManager(OptionSet optionManager,
}
}
+ /**
+ * Specifies whether to plan based on the legacy meaning of "*". See
+ * <a href="https://issues.apache.org/jira/browse/DRILL-5542";>DRILL-5542</a>.
+ * If true, then the star column <i>includes</i> implicit and partition
+ * columns. If false, then star matches <i>only</i> table columns.
+ *
+ * @param optionManager access to the options for this query; used
+ * too look up custom names for the metadata columns
+ * @param config implicit column options
+ */
+ public ImplicitColumnManager(OptionSet optionManager,
Review comment:
For testing, would be much better to resolve options in the caller. I've
tried to keep dependencies minimal in these classes to simplify testing and to
separate responsibilities. This class cares about the flag, not its source.
Also, the technical term for "star column" is "wildcard."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
