paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392607989
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadata.java
##########
@@ -74,4 +81,8 @@ public int dirPathLength() {
}
public boolean isSet() { return filePath != null; }
+
+ public String getImplicitColumnValue(ColumnExplorer.ImplicitFileColumn
column) {
+ return ColumnExplorer.getImplicitColumnValue(column, filePath, fs);
Review comment:
The prior version returned values based on the static file name and path; no
need for the file system. How has that changed here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services