vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement 
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392681793
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadata.java
 ##########
 @@ -74,4 +81,8 @@ public int dirPathLength() {
   }
 
   public boolean isSet() { return filePath != null; }
+
+  public String getImplicitColumnValue(ColumnExplorer.ImplicitFileColumn 
column) {
+    return ColumnExplorer.getImplicitColumnValue(column, filePath, fs);
 
 Review comment:
   Except for the information which may be obtained from the file name, we now 
require such things as last modified time, which may be obtained only with file 
system usage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to