vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392719079
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/ReaderSchemaOrchestrator.java
##########
@@ -118,9 +135,59 @@ public void endBatch() {
// Fill in the null and metadata columns.
populateNonDataColumns();
}
+ if (projected) {
+ setProjectMetadata(null);
+ }
rootTuple.setRowCount(tableContainer.getRecordCount());
}
+ /**
+ * Updates {@code PROJECT_METADATA} implicit column value to {@code "FALSE"}
to handle current batch as
+ * a batch with metadata information only for the case when this batch is
first and empty.
+ */
Review comment:
I need to add this logic before implicit columns are resolved, so their
values will be populated for a single row. I didn't find another place, where
it may be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
