paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r394689649
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/metastore/store/SimpleFileTableMetadataProvider.java
##########
@@ -97,47 +100,38 @@ public FileMetadata getFileMetadata(Path location) {
@Override
public NonInterestingColumnsMetadata getNonInterestingColumnsMetadata() {
- return null;
+ return new NonInterestingColumnsMetadata(Collections.emptyMap());
Review comment:
Better name? `NonInteresting` --> `Uninteresting`?
But, why are they not interesting? Is it because they we don't track their
statistics? Is so, maybe we can define a term "tracked? untracked?" to describe
those columns which do (or do not) participate in statistics. I did a quick
check or Oracle, Postgres and SqlServer, but I didn't find a good term. Maybe
"excluded columns"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
