vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r395153171
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadata.java
##########
@@ -31,9 +32,15 @@
private final Path filePath;
private final String[] dirPath;
+ private final FileSystem fs;
public FileMetadata(Path filePath, Path selectionRoot) {
+ this(filePath, selectionRoot, null);
+ }
+
+ public FileMetadata(Path filePath, Path selectionRoot, FileSystem fs) {
Review comment:
This class has good JavaDoc which explains the relation between `filePath`
and `selectionRoot`. The file system should accept paths with or without file
system prefix, so no additional relation is introduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
