ihuzenko commented on a change in pull request #2031: DRILL-7650: Add option to enable Jetty's dump for troubleshooting URL: https://github.com/apache/drill/pull/2031#discussion_r395015959
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java ########## @@ -163,6 +163,7 @@ public void start() throws Exception { embeddedJetty.addConnector(connector); final boolean portHunt = config.getBoolean(ExecConstants.HTTP_PORT_HUNT); + embeddedJetty.setDumpAfterStart(config.getBoolean(ExecConstants.HTTP_JETTY_SERVER_DUMP_AFTER_START)); Review comment: Could you please explain why? The method called already before the port hunting loop. Moving it below doesn't make sense since it will be too late to set the flag on ```embeddedJetty``` object. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services