vvysotskyi commented on a change in pull request #2031: DRILL-7650: Add option 
to enable Jetty's dump for troubleshooting
URL: https://github.com/apache/drill/pull/2031#discussion_r395021565
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
 ##########
 @@ -163,6 +163,7 @@ public void start() throws Exception {
     embeddedJetty.addConnector(connector);
 
     final boolean portHunt = config.getBoolean(ExecConstants.HTTP_PORT_HUNT);
+    
embeddedJetty.setDumpAfterStart(config.getBoolean(ExecConstants.HTTP_JETTY_SERVER_DUMP_AFTER_START));
 
 Review comment:
   It is a minor comment. Placing it after declaring the `portHunt` variable 
and before the loop where port hunting happens enforces to think that it should 
be somehow connected with port hunting. Please move it above declaring the 
`portHunt` variable if possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to