paul-rogers commented on a change in pull request #2042: DRILL-7672: Make
metadata type required when reading from / writing into Drill Metastore
URL: https://github.com/apache/drill/pull/2042#discussion_r399614392
##########
File path:
metastore/iceberg-metastore/src/test/java/org/apache/drill/metastore/iceberg/components/tables/TestIcebergTablesMetastore.java
##########
@@ -297,6 +302,7 @@ public void testOverwrite() {
.workspace(tableInfo.workspace())
.tableName(tableInfo.name())
.metadataKey("dir0")
+ .metadataType(MetadataType.TABLE.name())
Review comment:
Some of these use the `MetadataType.TABLE`, others
`MetadataType.TABLE.name()`. Do the tests make sure both work, or should they
be uniform?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
