arina-ielchiieva commented on a change in pull request #2042: DRILL-7672: Make
metadata type required when reading from / writing into Drill Metastore
URL: https://github.com/apache/drill/pull/2042#discussion_r399688777
##########
File path:
metastore/iceberg-metastore/src/main/java/org/apache/drill/metastore/iceberg/components/tables/IcebergTables.java
##########
@@ -42,16 +45,15 @@
*/
public class IcebergTables implements Tables,
MetastoreContext<TableMetadataUnit> {
- public static final String STORAGE_PLUGIN = "storagePlugin";
- public static final String WORKSPACE = "workspace";
- public static final String TABLE_NAME = "tableName";
- public static final String METADATA_KEY = "metadataKey";
-
/**
* Metastore Tables component partition keys, order of partitioning will be
determined based
* on order in {@link List} holder.
*/
- private static final List<String> PARTITION_KEYS =
Arrays.asList(STORAGE_PLUGIN, WORKSPACE, TABLE_NAME, METADATA_KEY);
+ private static final List<String> PARTITION_KEYS = Arrays.asList(
+ TableInfo.STORAGE_PLUGIN,
+ TableInfo.WORKSPACE,
+ TableInfo.TABLE_NAME,
+ MetadataInfo.METADATA_KEY);
Review comment:
Actually this a good idea to pull all Metastore column names into one place.
I have created `MetastoreColumn` enum where all columns and their names are
stored. Also made sure that in the code we refer only to `MetastoreColumn` and
not to its string representation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
