paul-rogers commented on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615408581 @arina-ielchiieva, thanks much for running the tests! Looks like these failures are due to the verifying the incorrect prior behavior where the default field delimiter was newline (same as the line delimiter), not comma. This PR changes the default to comma. Let's consider an example. For this query: ``` select * from table(`table_function/cr_lf.csv`(type=>'text', lineDelimiter=>'\r\n')); ``` With this input: ``` 1,aaa,bbb 2,ccc,ddd 3,eee, 4,fff,ggg ``` We currently expect this output because the old default field delimiter is a newline (same as the line delimiter): ``` ["1,aaa,bbb"] ["2,ccc,ddd"] ["3,eee,"] ["4,fff,ggg"] ``` The correct expected results, with a default field delimiter of comma, is: ``` ["1","aaa","bbb"] ["2","ccc","ddd"] ["3","eee",""] ["4","fff","ggg"] ``` Will investigate how to fix the tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
