paul-rogers edited a comment on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615934230 @arina-ielchiieva, yes, we can modify the queries to force the incorrect behavior. We could add a yet another option to turn off inheritance and keep the old behavior. However, I'd argue that the old results were actually wrong, and the new results are correct. So, if we modify anything, it seems the best approach is to modify the expected results to reflect the correct behavior, and let the old versions fail because they were, in fact, wrong. Actually, it is possible to modify the query to produce the correct results on old versions: we just specify values for the fields which are inherited in Drill 1.18. Doing so will mask the old, incorrect, behavior, and won't test the new behavior. Yet another option is to modify the framework. In addition to the `.q`, and `.e` files, add a `.p` (parameters) file and the supporting code. For example: ``` validTo: "1.17" ``` For the old queries, and: ``` validFrom: "1.18" ``` For the new queries. Better would be to use commit IDs, but those are not ordered. We used to have this problem all the time back when Drill was taking shape. We never did solve it: we just updated the tests and moved on. Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
