luocooong commented on a change in pull request #2158:
URL: https://github.com/apache/drill/pull/2158#discussion_r567394749
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
##########
@@ -231,13 +217,7 @@ public DrillClient getClient() {
@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {
Review comment:
Currently, `setAutoCommit()` override super class method but didn't do
anything, is right?
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/util/StoragePluginTestUtils.java
##########
@@ -46,13 +43,6 @@
public static final String ROOT_SCHEMA = "root";
public static final String DFS_TMP_SCHEMA = DFS_PLUGIN_NAME + "." +
TMP_SCHEMA;
- public static final String DFS_DEFAULT_SCHEMA = DFS_PLUGIN_NAME + "." +
SchemaFactory.DEFAULT_WS_NAME;
Review comment:
Would these changes affect the test unit with marked `@ignore`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
