vvysotskyi commented on a change in pull request #2158:
URL: https://github.com/apache/drill/pull/2158#discussion_r567409451
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/util/StoragePluginTestUtils.java
##########
@@ -46,13 +43,6 @@
public static final String ROOT_SCHEMA = "root";
public static final String DFS_TMP_SCHEMA = DFS_PLUGIN_NAME + "." +
TMP_SCHEMA;
- public static final String DFS_DEFAULT_SCHEMA = DFS_PLUGIN_NAME + "." +
SchemaFactory.DEFAULT_WS_NAME;
Review comment:
No, they shouldn't affect any tests. The logic responsible for creating
workspaces for tests was updated and moved from `DrillConnectionImpl` to the
`JdbcTestBase` class, and these constants aren't required anymore.
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
##########
@@ -231,13 +217,7 @@ public DrillClient getClient() {
@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {
Review comment:
Yes, it is correct. Drill doesn't support transactions, so we shouldn't
apply the logic from the parent method, but we also shouldn't throw an error as
we did before to be compatible with [Python Database API Specification
v2.0](https://www.python.org/dev/peps/pep-0249/#commit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
