cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r582491028
##########
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##########
@@ -323,53 +328,20 @@ private void openFile(FileSchemaNegotiator negotiator)
throws IOException {
InputStream in = null;
try {
in =
negotiator.fileSystem().openPossiblyCompressedStream(split.getPath());
- IHDF5Factory factory = HDF5FactoryProvider.get();
- inFile = convertInputStreamToFile(in);
- hdf5Reader = factory.openForReading(inFile);
+ hdfFile = HdfFile.fromInputStream(in);
Review comment:
Interesting. The BatchReader has a `close()` method which is executed
when Drill is finished reading the file. Is there a method in JHDF to purge
the temp files, or would you suggest using a different method to load the file?
https://github.com/apache/drill/blob/5729e1f921eaceac8647ee6eee24a4c2bb31e21e/contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java#L1229-L1236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
