jamesmudd commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584244957
##########
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##########
@@ -323,53 +328,20 @@ private void openFile(FileSchemaNegotiator negotiator)
throws IOException {
InputStream in = null;
try {
in =
negotiator.fileSystem().openPossiblyCompressedStream(split.getPath());
- IHDF5Factory factory = HDF5FactoryProvider.get();
- inFile = convertInputStreamToFile(in);
- hdf5Reader = factory.openForReading(inFile);
+ hdfFile = HdfFile.fromInputStream(in);
Review comment:
I guess it depends what file sizes you are expecting. If your files will
fit in memory then it's probably a better option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
