vdiravka commented on a change in pull request #2192:
URL: https://github.com/apache/drill/pull/2192#discussion_r602931658
##########
File path:
contrib/format-pcapng/src/main/java/org/apache/drill/exec/store/plugin/PcapFormatConfig.java
##########
@@ -29,18 +29,23 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonTypeName;
-@JsonTypeName(PcapngFormatConfig.NAME)
+@JsonTypeName(PcapFormatConfig.NAME)
@JsonInclude(JsonInclude.Include.NON_DEFAULT)
-public class PcapngFormatConfig implements FormatPluginConfig {
+public class PcapFormatConfig implements FormatPluginConfig {
+ private static final List<String> DEFAULT_EXTNS = ImmutableList.of("pcap",
"pcapng");
- public static final String NAME = "pcapng";
+ public static final String NAME = "pcap";
private final List<String> extensions;
private final boolean stat;
+ private final boolean sessionizeTCPStreams;
@JsonCreator
- public PcapngFormatConfig(@JsonProperty("extensions") List<String>
extensions, @JsonProperty("stat") boolean stat) {
- this.extensions = extensions == null ?
ImmutableList.of(PcapngFormatConfig.NAME) : ImmutableList.copyOf(extensions);
+ public PcapFormatConfig(@JsonProperty("extensions") List<String> extensions,
+ @JsonProperty("stat") boolean stat,
+ @JsonProperty("sessionizeTCPStreams") Boolean
sessionizeTCPStreams) {
Review comment:
Agree. But in was not introduced by me. This field was present in the
original `pcap` format config:
```
@JsonCreator
public PcapFormatConfig(
@JsonProperty("extensions") List<String> extensions,
@JsonProperty("sessionizeTCPStreams") Boolean sessionizeTCPStreams) {
```
It is need to left it for backward compatibility of old PCAP format plugin
configs. Or I can create new one `sessionize` and if `sessionizeTCPStreams` is
present in config, assign it to new `sessionize`. Sounds reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
