paul-rogers commented on pull request #2192: URL: https://github.com/apache/drill/pull/2192#issuecomment-812924446
Where are we on this one? We should avoid the "boil the ocean" temptation: the desire to fix too many things in one PR. If this PR will break upgrades, then the team can decide if that is OK for the handful of people who might be affected. Maybe document recovery in release notes, or be prepared to describe the steps on Slack or the mail lists. I am concerned about table functions. They are obscure, but are supposed to work. I'd like to see a test added so we can be sure that the non-public config variables do, in fact, work. Of course, you could argue that we can skip that until someone complains, then file another bug because, again, there are likely few users of this plugin and likely none of them use table functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
