vvysotskyi commented on a change in pull request #2244:
URL: https://github.com/apache/drill/pull/2244#discussion_r644958707
##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
<artifactId>drill-protocol</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
<dependency>
<!-- add as provided scope so that we can compile TestTools. Should
only be ever used in a test scenario where someone else is bringing JUnit in.
-->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>${junit.version}</version>
+ <scope>provided</scope>
Review comment:
`exec` module is the parent for `java-exec` and it contains the
dependency to `drill-common` with `tests` classifier, so it should be enaugh
just to move
`common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java` class
to `common/test/main/java/org/apache/drill/common/util/RepeatTestRule.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
