martin-g commented on a change in pull request #2244:
URL: https://github.com/apache/drill/pull/2244#discussion_r644947522
##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
<artifactId>drill-protocol</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
<dependency>
<!-- add as provided scope so that we can compile TestTools. Should
only be ever used in a test scenario where someone else is bringing JUnit in.
-->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>${junit.version}</version>
+ <scope>provided</scope>
Review comment:
@vvysotskyi RepeatTestRule is currently at
common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java
But it is used by:
1)
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
2) common/src/test/java/org/apache/drill/test/TestTools.java
So, to do what you suggest I have to copy it in two modules - java-exec and
common.
Or to move it in common/src/test/... and then in java-exec/pom.xml to add a
dependency to common-tests.jar
##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
<artifactId>drill-protocol</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
<dependency>
<!-- add as provided scope so that we can compile TestTools. Should
only be ever used in a test scenario where someone else is bringing JUnit in.
-->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>${junit.version}</version>
+ <scope>provided</scope>
Review comment:
Done!
##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
<artifactId>drill-protocol</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit.version}</version>
Review comment:
@laurentgo Very good suggestions!
I've pushed a new commit that uses the junit-bom in dependencyManagement,
and uses junit-jupiter instead of junit-jupiter-engine. This way
junit-jupiter-api, junit-jupiter-engine and junit-jupiter-params are included
as transitive dependencies and one could write use the full power of JUnit 5.x
when writing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
