jfmario commented on pull request #2256:
URL: https://github.com/apache/drill/pull/2256#issuecomment-858812676


   @cgivre I think a lot of this looks good. I noticed that when I query an API 
and receive a 404 response with no body, Drill throws an error instead of 
giving me those fields.
   
   I think there may be cases where that is preferred, but my view is that a 
404 with no body is an informative response and not an error, so I would have 
preferred to see the "fact of" the 400 response in the returning table. The 
same thing applies to other 400 errors.
   
   This may be something that users want to configure. I think 500s are always 
errors, but if you add a configuration it may be worth letting users specify 
which status codes should be treated as errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to