cgivre commented on a change in pull request #2256:
URL: https://github.com/apache/drill/pull/2256#discussion_r659337823
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
##########
@@ -171,6 +175,12 @@ public InputStream getInputStream() {
.newCall(request)
.execute();
+ // Preserve the response
+ responseMessage = response.message();
+ responseCode = response.code();
+ responseProtocol = response.protocol().toString();
+ responseURL = response.request().url().toString();
Review comment:
I'm fairly certain that by definition these fields will be populated.
For instance, in order to get a response, you have to send data to a URL, hence
that URL will be defined in the response. I added a null check and the IDE
complained and confirmed that `protocol` and the `url` field will never be
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
