dzamo commented on a change in pull request #2264:
URL: https://github.com/apache/drill/pull/2264#discussion_r657997077
##########
File path: exec/java-exec/src/main/codegen/data/MathFunc.tdd
##########
@@ -125,7 +125,7 @@ unaryMathFunctions : [
{input: "UInt8", outputType: "UInt8", castType: "long"}
]
},
- {className: "Mod", funcName: "mod", javaFunc : " % ", types: [
+ {className: "Mod", funcName: "mod", aliasName: "", javaFunc : " % ",
types: [
Review comment:
I believe it does handle all widths already. If you look a full listing
of MathFunc.tdd, rather than what this diff reveals, you'll see integer types
from 8 bits to 64 bits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
