dzamo commented on a change in pull request #2264:
URL: https://github.com/apache/drill/pull/2264#discussion_r658003252
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BitFunctions.java
##########
@@ -71,22 +70,4 @@ public void eval() {
}
}
Review comment:
The addition of xor to MathFunc.tdd made it a redundant special case:
32-bit ints are already provided for by the new FreeMarker version. We get a
small bit of clean-up for free here because the deleted IntXor function was out
of place in BitFunctions.java, which otherwise only contains functions that
operate on the boolean type BIT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
