dzamo commented on pull request #2268: URL: https://github.com/apache/drill/pull/2268#issuecomment-878090634
@oleg-zinovev thanks for adapting your solution to java.time. I agree that the API it offers for this problem looks like a downgrade but there is already an initiative in Drill to migrate from Joda to java.time, as Joda warns us that we should. There are some other issues I can see. There is a @Workspace variable being used but 1) it's not a Holder type and 2) this is a simple function not an aggregate function. I'm going to pull your PR branch down to my machine to look more closely at this so we can get this important fix merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
