luocooong commented on a change in pull request #2278:
URL: https://github.com/apache/drill/pull/2278#discussion_r675481061
##########
File path:
contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkConnection.java
##########
@@ -71,10 +73,13 @@ public Service connect() {
loginArgs.setPort(port);
loginArgs.setPassword(credentials.getPassword());
loginArgs.setUsername(credentials.getUsername());
-
try {
+ connectionAttempts--;
service = Service.connect(loginArgs);
} catch (Exception e) {
Review comment:
Does it need to sleeping for a few seconds?
##########
File path:
contrib/storage-splunk/src/main/resources/bootstrap-storage-plugins.json
##########
@@ -8,7 +8,8 @@
"port": 8089,
"earliestTime": "-14d",
"latestTime": "now",
- "enabled": false
+ "enabled": false,
Review comment:
Is it possible to put the `enabled` at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
